Values will occasionally NaN when width and height cannot be obtained fr...#59
Open
DotFreelance wants to merge 1 commit intostowball:masterfrom
Open
Values will occasionally NaN when width and height cannot be obtained fr...#59DotFreelance wants to merge 1 commit intostowball:masterfrom
DotFreelance wants to merge 1 commit intostowball:masterfrom
Conversation
… from ‘item’ object. Added code to check values and use this.width/this.height instead.
Author
|
When importing this library into a rather large project, found that occasionally the w and h variables would be 0, resulting in a divide by zero and an infinity/NaN result which completely disables the image maps. Adding the 4 lines of code corrected this problem. The code will not supersede what already exists. |
|
This pull request should really be accepted. I had this exact problem as well and this fix worked. |
|
I used naturalHeight and naturalWidth but essentially its the same fix. Thanks for the pointers! |
kycasdzxc
approved these changes
May 1, 2024
kycasdzxc
approved these changes
May 1, 2024
| if(!w) | ||
| w = this.width; | ||
| if(!h) | ||
| h = this.height; |
There was a problem hiding this comment.
There was a bug like the one below, but thanks to you, I solved it. thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...om ‘item’ object. Added code to check values and use this.width/this.height instead.